!DNMY - WIP! Wiring up the front end to use call the opportunities API with search #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alifhughes
commented
Apr 21, 2021
•
alifhughes
commented
- Still WIP
- I didn't have enough time to finish this but I hope it serves as a jumping off point for someone who will implement this page
- Gif included demonstrates how it works
- Not sure if this is the best/right way to implement this, I think not - but hopefully it will be useful in someway
SamphireReeve
approved these changes
Apr 22, 2021
stefanha
reviewed
Apr 22, 2021
| @@ -10,7 +10,7 @@ | |||
| </q-card-section> | |||
| <!-- search bar --> | |||
| <q-toolbar> | |||
| <q-input rounded outlined class="search-bar" v-model="filter" type="text" > | |||
| <q-input rounded outlined class="search-bar" v-on:input="filterOpportunities" v-model="filter" type="text" > | |||
There was a problem hiding this comment.
debounce="500" can be added to hold off on filterOpportunities() calls for 500 milliseconds to avoid flooding the server with REST API calls while the user is typing.
stefanha
reviewed
Apr 22, 2021
| }) | ||
| let results = [] | ||
|
|
||
| this.$axios.get('/api/v1/opportunities/?search=' + this.filter.toLowerCase(), |
There was a problem hiding this comment.
URL encoding will be necessary to handle characters that cannot be in URLs or have a special meaning (like "&").
stefanha
reviewed
Apr 22, 2021
|
|
||
| results = results.filter(o => { | ||
| return o.date.toLowerCase().indexOf(this.filterDate.toLowerCase()) > -1 | ||
| }) | ||
|
|
||
| return results |
There was a problem hiding this comment.
I think this return value is unused and results can be removed. The UI update happens when this.opportunities is assigned above.
|
Thank you, @alifhughes. I posted some comments if you or someone else want to work further on this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.