Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user set health check interval #150

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add support for user set health check interval #150

merged 1 commit into from
Apr 15, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Apr 15, 2024 •
edited
Loading

closes #149

Description

Maps healthCheckInterval into settings so that a user set value can be passed to the Launcher.start call

NOTES:

Related Issue(s)

#149

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

This was referenced Apr 15, 2024
Merged
Closed
Closed
Merged
@Steve-Mcl Steve-Mcl requested a review from hardillb April 15, 2024 11:46
hardillb
hardillb reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking on defaults

kubernetes.js Show resolved Hide resolved
@hardillb hardillb merged commit 7a8c55e into main Apr 15, 2024
3 checks passed
@hardillb hardillb deleted the 149-health-check-interval branch April 15, 2024 15:00
@knolleary
Copy link
Member

Proposing this is reverted - FlowFuse/flowfuse#3578 (comment)

@Steve-Mcl Steve-Mcl mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Instance Health Check interval to be configured
3 participants
@Steve-Mcl @knolleary @hardillb