-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement health check interval user setting #3716
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
==========================================
+ Coverage 79.13% 79.16% +0.02%
==========================================
Files 279 279
Lines 12550 12567 +17
Branches 2787 2792 +5
==========================================
+ Hits 9932 9949 +17
Misses 2618 2618
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggested changes.
I'm iffy on the idea of adding a Launcher section to Instance settings as it becomes another concept for a user to have to understand the meaning of. That said, I don't think we have quite a suitable existing location for such a setting. So won't block for that - but the other bits I would like looked at.
Co-authored-by: Nick O'Leary <[email protected]>
@knolleary, hold fire on review/merge please. Not able to navigate to new tab in pre-staging env tests. |
Added NOTE: The PG test fail is unrelated and was raised as a chore - found when implementing SQL Server as backend DB. It has finally bitten! Test fail:
failing due to missing
I will raise a PR and once merged, re-run tests. |
Rerun tests once Fix async and transactional issues in code base #3812 is merged |
My only pause on merging this right now is that it depends on the updated |
Description
KEY_HEALTH_CHECK_INTERVAL
launcherSettings
to be passed in/outinstance/<instance-id>/settings/launcher
NOTES:
/api/v1/projects/:id
launcherSettings
(negates need for future changes to API schema)ProjectSettings
under own KEYKEY_HEALTH_CHECK_INTERVAL
object
if desired (would not affect public facing API since that was set up as an object by design for such eventualities)Screenshots
Settings:
In actions:
Audit log entry:
TODO
Related Issue(s)
#3715
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label