-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for web as a platform #330
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 86a162d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"@expo/vector-icons": "^14.0.0", | ||
"@gorhom/bottom-sheet": "^4", | ||
"@react-native-community/slider": "4.5.2", | ||
"@react-native-community/slider": "4.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgraded this version to resolve callstack/react-native-slider#617 which I could replicate while testing the sliders in the example app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so awesome!
My only question is what's the story behind getGlyphWidths
vs measureText
changes?
@zibs |
Fixes #223
Required before #305 can be worked on.
Description
When trying to use Victory Native in an Expo Snack, I found that the default web platform was erroring.
This led me to investigate why Vistory Native was not working on the web platform, and subsequently this PR where I've fixed the issues and updated the example app so that it can easily be run on the web, as well an Android and iOS.
Known Issues
The
pie-and-donut-charts
screen contains 8 separate graphs, which is too many for my current browser (Arc) to render.WARNING: Too many active WebGL contexts. Oldest context will be lost.
is logged to the console, and only the last three graphs are rendered. It seems there is no such limitation on iOS or Android.I have not refactored that example screen in this PR to keep this PR smaller.
To overcome the limit of active WebGL contexts, we could refactor the screen into an accordion or split it into multiple screens.
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass@react-native-community/slider
not matching the Expo recommended version.