-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for web as a platform #330
Merged
+153
−28
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ffc1bb9
fix: Migrate measureText to getGlyphWidths for RNWeb support
robwalkerco f150539
Fix: Flatten the style prop for Canvas, as required by the web versio…
robwalkerco fb9f2ee
lint: Clean up style props
robwalkerco 46a77a4
Fix: Update example project to add web support
robwalkerco fa4714f
lint
robwalkerco 86a162d
changeset
robwalkerco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"example": minor | ||
"victory-native": minor | ||
--- | ||
|
||
Added support for Expo web as a platform |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import "@expo/metro-runtime"; | ||
import { App } from "expo-router/build/qualified-entry"; | ||
import { renderRootComponent } from "expo-router/build/renderRootComponent"; | ||
|
||
// eslint-disable-next-line import/no-unresolved | ||
import { version } from "canvaskit-wasm/package.json"; | ||
|
||
import { LoadSkiaWeb } from "@shopify/react-native-skia/lib/module/web"; | ||
|
||
// When used on the web, we need to load the CanvasKit WASM file before rendering content | ||
// For simplicity, we are using a CDN to load the file, but it can be hosted on your own server as well | ||
// See https://shopify.github.io/react-native-skia/docs/getting-started/web for more details | ||
LoadSkiaWeb({ | ||
locateFile: (file) => | ||
`https://cdn.jsdelivr.net/npm/canvaskit-wasm@${version}/bin/full/${file}`, | ||
}).then(async () => { | ||
renderRootComponent(App); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgraded this version to resolve callstack/react-native-slider#617 which I could replicate while testing the sliders in the example app.