Installation: do not recommend to delete the .spack directory#216
Installation: do not recommend to delete the .spack directory#216marcpaterno merged 1 commit intoFramework-R-D:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the potentially dangerous step that recommended deleting the ~/.spack directory from the installation instructions, helping to protect users from accidentally removing their own content or configurations.
- Removed Step 2 which instructed users to run
rm -rf $HOME/.spack - Renumbered subsequent installation steps from Step 3-8 to Step 2-7
| ``` | ||
|
|
||
| Then make sure you don't already have a spack command on your PATH: | ||
| ```bash |
There was a problem hiding this comment.
Line 25 has trailing whitespace after the word "spack". This violates the project's text formatting standards which require no trailing whitespace on any line.
| ```bash | ||
| source ${HOME}/spack/share/spack/setup-env.sh | ||
| ``` | ||
| `which spack` will show that `spack` is a bash function. |
There was a problem hiding this comment.
Line 41 has trailing whitespace after "function.". This violates the project's text formatting standards which require no trailing whitespace on any line.
| ```bash | ||
| git clone --depth=2 https://github.com/spack/spack.git | ||
| ``` | ||
| If you encounter trouble, consult the [installation instructions from the Spack project]( https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial). |
There was a problem hiding this comment.
This line contains a bare URL that should be formatted as a proper Markdown link. The URL has an extra space after the opening bracket which creates an invalid Markdown link syntax. The space after the opening parenthesis in "( https" should be removed.
| If you encounter trouble, consult the [installation instructions from the Spack project]( https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial). | |
| If you encounter trouble, consult the [installation instructions from the Spack project](https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial). |
This avoid inadvertently removing user content.