Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions INSTALLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,32 +21,27 @@ mkdir -p ${PHLEX_WORK_DIR}
cd ${PHLEX_WORK_DIR}
```

Step 2: remove any previous user-level Spack installation
```bash
rm -rf $HOME/.spack
```

Then make sure you don't already have a spack command on your PATH:
```bash
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 25 has trailing whitespace after the word "spack". This violates the project's text formatting standards which require no trailing whitespace on any line.

Copilot generated this review using guidance from repository custom instructions.
which spack
```
should tell you there is no spack in your PATH.

Step 3: install Spack
Step 2: install Spack

```bash
git clone --depth=2 https://github.com/spack/spack.git
```
If you encounter trouble, consult the [installation instructions from the Spack project]( https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial).
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains a bare URL that should be formatted as a proper Markdown link. The URL has an extra space after the opening bracket which creates an invalid Markdown link syntax. The space after the opening parenthesis in "( https" should be removed.

Suggested change
If you encounter trouble, consult the [installation instructions from the Spack project]( https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial).
If you encounter trouble, consult the [installation instructions from the Spack project](https://spack-tutorial.readthedocs.io/en/latest/tutorial_basics.html#basics-tutorial).

Copilot uses AI. Check for mistakes.

Step 4: make spack available at the command line.
Step 3: make spack available at the command line.
```bash
source ${HOME}/spack/share/spack/setup-env.sh
```
`which spack` will show that `spack` is a bash function.
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 41 has trailing whitespace after "function.". This violates the project's text formatting standards which require no trailing whitespace on any line.

Copilot generated this review using guidance from repository custom instructions.


Step 5: Modify the Spack configuration to avoid filling `/tmp`.
Step 4: Modify the Spack configuration to avoid filling `/tmp`.
This is not at all related to Phlex, but until there is spack documentation describing this, we recommend it as good practice.

Run the following, which will open an editor.
Expand All @@ -64,8 +59,8 @@ config:

### Ensuring a sufficient compiler

Step 6: ensure that spack has access to a new enough GCC.
Currently this means GCC 14.
Step 5: ensure that spack has access to a new enough GCC.
Currently this means GCC 14.

Run `spack compilers` to see what compilers Spack knows about.
It may tell you to run `spack compiler find` to autodetect compilers.
Expand All @@ -81,7 +76,7 @@ Building GCC may take

### Creating and installing the Phlex environment

Step 7: Add the Spack recipe repositories needed by Phlex:
Step 6: Add the Spack recipe repositories needed by Phlex:

```bash
spack repo add https://github.com/FNALssi/fnal_art.git
Expand All @@ -90,7 +85,7 @@ spack repo add https://github.com/Framework-R-D/phlex-spack-recipes.git

After you have done this, `spack repo list` should show that you have (among others) a repository named `phlex` available to Spack.

Step 8: Create a spack environment and install phlex
Step 7: Create a spack environment and install phlex

To guide the creation of the environment, download the environment configuration file, and create the environment it describes:

Expand Down
Loading