Improve Phlex test coverage

[greenc-FNAL]

Factored out of #329.

• Improve test coverage of Phlex code

[Copilot]

Pull request overview

This PR improves test coverage for Phlex core components and modernizes the build system by using cet_make_exec() for the main executable. The changes enhance test coverage for identifier operations, data cell index methods, algorithm name handling, consumer functionality, and internal validation functions, while ensuring the build system follows cetmodules conventions.

Changes:

• Switch from add_executable() to cet_make_exec() for the phlex executable and update all test references to use the namespaced phlex::phlex alias
• Add comprehensive test coverage for data_cell_index methods including comparisons, string formatting, parent lookup, and layer path
• Add new test file core_misc_test.cpp covering algorithm_name, consumer, verify_name, and add_to_error_messages functionality
• Add test coverage for identifier comparison operators
• Add fmt::formatter specialization for identifier type to support formatting

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
phlex/app/CMakeLists.txt	Modernizes build by using cet_make_exec() instead of add_executable(), which creates the phlex::phlex alias and handles installation automatically
test/python/CMakeLists.txt	Updates test commands to use phlex::phlex alias instead of bare phlex
test/plugins/CMakeLists.txt	Updates TEST_EXEC to use phlex::phlex alias
test/mock-workflow/CMakeLists.txt	Updates TEST_EXEC to use phlex::phlex alias
test/max-parallelism/CMakeLists.txt	Updates TEST_EXEC to use phlex::phlex alias for all parallelism tests
test/form/CMakeLists.txt	Updates TEST_EXEC to use phlex::phlex alias
test/benchmarks/CMakeLists.txt	Updates TEST_EXEC to use phlex::phlex alias
test/CMakeLists.txt	Adds new core_misc_test executable with dependencies on phlex::core and Boost::json
test/identifier.cpp	Adds test coverage for identifier comparison operators (==, !=, <, <=, >=)
test/data_cell_index.cpp	Adds comprehensive test cases for comparisons, to_string, parent lookup, layer_path, and base access
test/core_misc_test.cpp	New test file covering algorithm_name creation/matching, consumer construction, verify_name validation, and add_to_error_messages functionality
phlex/model/identifier.hpp	Adds fmt::formatter specialization for identifier type to support use with fmt::format and fmt::print

[Copilot]

The assertion id1 < id2 || id2 < id1 is a tautology that will always be true for any two distinct identifiers, since we already established they're not equal on line 73. This doesn't meaningfully test the less-than operator. Consider replacing with assert(id1 < id2); to specifically verify the comparison relationship between "abc" and "def", or split it into two separate assertions to test both directions with known values.

Suggested change

	assert(id1 < id2 || id2 < id1);
	assert(id1 < id2);

[beojan]

Not if the operators are defined incorrectly.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   80.39%   81.43%   +1.03%     
==========================================
  Files         127      127              
  Lines        3102     3103       +1     
  Branches      547      547              
==========================================
+ Hits         2494     2527      +33     
+ Misses        381      355      -26     
+ Partials      227      221       -6     

Flag	Coverage Δ
unittests	81.43% <100.00%> (+1.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
phlex/model/identifier.hpp	75.00% <100.00%> (-10.72%)	⬇️

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f508fb6...6b2fae7. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.