Revert "Improve Phlex test coverage"

[greenc-FNAL]

Reverts #335

[Copilot]

Pull request overview

This PR reverts PR #335, which had added test coverage improvements to the Phlex project. The revert removes additional tests for identifier operations, comprehensive data_cell_index test cases, and a new core_misc_test file covering algorithm_name, consumer, and verify_name functionality. It also removes a redundant fmt::formatter specialization for identifier (the format_as function provides equivalent functionality).

Changes:

• Removes additional identifier comparison and operator test coverage from test/identifier.cpp
• Removes comprehensive data_cell_index test cases covering comparisons, to_string, parent lookup, layer_path, and base access
• Deletes test/core_misc_test.cpp entirely (107 lines of test coverage for algorithm_name, consumer, and verify_name)
• Removes the core_misc_test build configuration from test/CMakeLists.txt
• Removes redundant fmt::formatter specialization from phlex/model/identifier.hpp (format_as provides equivalent functionality)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/identifier.cpp	Removes additional test coverage for identifier edge cases (equality, inequality, comparison operators)
test/data_cell_index.cpp	Removes comprehensive test suite covering data_cell_index methods (comparisons, to_string, parent lookup, layer_path, base access)
test/core_misc_test.cpp	Completely removes 107-line test file covering algorithm_name creation/matching, consumer tests, and verify_name validation
test/CMakeLists.txt	Removes build configuration for core_misc_test
phlex/model/identifier.hpp	Removes redundant fmt::formatter specialization (format_as function at line 57 provides equivalent functionality)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   82.24%   81.23%   -1.01%     
==========================================
  Files         127      127              
  Lines        3103     3102       -1     
  Branches      547      547              
==========================================
- Hits         2552     2520      -32     
- Misses        334      360      +26     
- Partials      217      222       +5     

Flag	Coverage Δ
unittests	81.23% <ø> (-1.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
phlex/model/identifier.hpp	85.71% <ø> (+10.71%)	⬆️

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d1adc...87c5d8d. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.