Revert "Improve test coverage of FORM code"

[greenc-FNAL]

Reverts #333

[Copilot]

Pull request overview

This PR reverts PR #333, which added test coverage for FORM code. The revert removes the test file (form_basics_test.cpp) and its CMake registration, and also reverts two code changes that were part of PR #333: removing inline keywords from factory functions in factories.hpp and changing the TEST_EXEC value from phlex::phlex back to phlex.

Changes:

• Removes the entire test/form/form_basics_test.cpp test file (188 lines)
• Removes the CMake test registration for the deleted test
• Reverts inline keywords from factory functions in form/util/factories.hpp
• Reverts TEST_EXEC value from phlex::phlex to phlex in the remaining form test

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test/form/form_basics_test.cpp	Removes the entire test file that tested FORM basic operations
test/form/CMakeLists.txt	Removes test registration and reverts TEST_EXEC to phlex
form/util/factories.hpp	Removes inline keywords from factory function definitions

[Copilot]

The TEST_EXEC value should be phlex::phlex, not phlex. This is the established convention throughout the codebase. All other tests in test/benchmarks/, test/max-parallelism/, test/mock-workflow/, test/plugins/, and test/python/ use phlex::phlex as the TEST_EXEC value. This revert should not change this line; it was already correct before PR #333.

Suggested change

	phlex
	phlex::phlex

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   82.24%   81.46%   -0.78%     
==========================================
  Files         127      127              
  Lines        3103     3103              
  Branches      547      547              
==========================================
- Hits         2552     2528      -24     
- Misses        334      354      +20     
- Partials      217      221       +4     

Flag	Coverage Δ
unittests	81.46% <ø> (-0.78%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/util/factories.hpp	45.00% <ø> (ø)

... and 9 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d1adc...db8560c. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[wwuoneway]

This looks fine for now. We may need to update the form test code in the future.