Skip to content

Revert "Improve test coverage of FORM code" #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenc-FNAL merged 1 commit into from
Feb 18, 2026
Merged

Revert "Improve test coverage of FORM code" #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions form/util/factories.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

namespace form::detail::experimental {

inline std::shared_ptr<IStorage_File> createFile(int tech, std::string const& name, char mode)
std::shared_ptr<IStorage_File> createFile(int tech, std::string const& name, char mode)
{
if (form::technology::GetMajor(tech) == form::technology::ROOT_MAJOR) {
#ifdef USE_ROOT_STORAGE
Expand All @@ -33,7 +33,7 @@ namespace form::detail::experimental {
return std::make_shared<Storage_File>(name, mode);
}

inline std::shared_ptr<IStorage_Container> createAssociation(int tech, std::string const& name)
std::shared_ptr<IStorage_Container> createAssociation(int tech, std::string const& name)
{
if (form::technology::GetMajor(tech) == form::technology::ROOT_MAJOR) {
if (form::technology::GetMinor(tech) == form::technology::ROOT_TTREE_MINOR) {
Expand All @@ -52,7 +52,7 @@ namespace form::detail::experimental {
return std::make_shared<Storage_Association>(name);
}

inline std::shared_ptr<IStorage_Container> createContainer(int tech, std::string const& name)
std::shared_ptr<IStorage_Container> createContainer(int tech, std::string const& name)
{
// Use the helper functions from Technology namespace for consistency
if (form::technology::GetMajor(tech) == form::technology::ROOT_MAJOR) {
Expand Down
7 changes: 1 addition & 6 deletions test/form/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,11 @@ cet_test(
job:form_module
HANDBUILT
TEST_EXEC
phlex::phlex
phlex
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TEST_EXEC value should be phlex::phlex, not phlex. This is the established convention throughout the codebase. All other tests in test/benchmarks/, test/max-parallelism/, test/mock-workflow/, test/plugins/, and test/python/ use phlex::phlex as the TEST_EXEC value. This revert should not change this line; it was already correct before PR #333.

Suggested change
phlex
phlex::phlex

Copilot uses AI. Check for mistakes.
TEST_ARGS
-c
${CMAKE_CURRENT_SOURCE_DIR}/form_test.jsonnet
TEST_PROPERTIES
ENVIRONMENT
"PHLEX_PLUGIN_PATH=${PROJECT_BINARY_DIR}:${CMAKE_BINARY_DIR}/form"
)

cet_test(form_basics_test USE_CATCH2_MAIN SOURCE form_basics_test.cpp LIBRARIES
form
)
target_include_directories(form_basics_test PRIVATE ${PROJECT_SOURCE_DIR}/form)
188 changes: 0 additions & 188 deletions test/form/form_basics_test.cpp
View file
Open in desktop

This file was deleted.

Loading