Skip to content

Fix clang-tidy readability-identifier-naming violations#381

Merged
greenc-FNAL merged 2 commits intomaintenance/clang-tidy-namingfrom
copilot/sub-pr-362
Mar 3, 2026
Merged

Fix clang-tidy readability-identifier-naming violations#381
greenc-FNAL merged 2 commits intomaintenance/clang-tidy-namingfrom
copilot/sub-pr-362

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

Renames identifiers across core graph node and registration code to satisfy the repository's readability-identifier-naming clang-tidy rules (lowercase for most identifiers, CamelCase for template parameters).

Changes

  • declared_fold.hpp: rresult_type (type alias); expand using result_type = std::decay_t<...> per reviewer suggestion; fix incomplete rename that left make_type_ids<r>() and std::unique_ptr<r> referencing an undeclared type
  • simple_ptr_map.hpp: Rename try_emplace parameter ptrnode_ptr to eliminate ptr ptr shadowing of the nested type alias
  • registrar.hpp: Rename constructor parameter nodesnode_map to eliminate nodes& nodes shadowing of the nested type alias
  • Transform/predicate/observer/unfold/fold nodes: Template parameters N/Mnum_inputs/num_outputs (single-letter names were flagged as too short and unclear)
  • CMakeLists.txt: Remove ENABLE_CLANG_TIDY option; update CLANG_TIDY_CONFIGURATION.md to reflect direct use of CMAKE_CXX_CLANG_TIDY

Example: parameter shadowing fixes

// Before
explicit registrar(nodes& nodes, ...);          // 'nodes' shadows type alias
auto try_emplace(std::string node_name, ptr ptr); // 'ptr' shadows type alias

// After
explicit registrar(nodes& node_map, ...);
auto try_emplace(std::string node_name, ptr node_ptr);

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix clang-tidy-flagged naming issues Fix clang-tidy readability-identifier-naming violations Mar 3, 2026
@greenc-FNAL greenc-FNAL marked this pull request as ready for review March 3, 2026 23:31
Copilot AI review requested due to automatic review settings March 3, 2026 23:31
@greenc-FNAL greenc-FNAL merged commit 63f563c into maintenance/clang-tidy-naming Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on resolving clang-tidy readability-identifier-naming issues by renaming identifiers (notably to avoid parameter/type alias shadowing) in Phlex’s core registration plumbing.

Changes:

  • Renamed the registrar constructor parameter from nodes to node_map to avoid nodes& nodes shadowing the nested using nodes = ... alias.

@greenc-FNAL greenc-FNAL deleted the copilot/sub-pr-362 branch March 10, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants