Fix clang-tidy readability-identifier-naming violations#381
Merged
greenc-FNAL merged 2 commits intomaintenance/clang-tidy-namingfrom Mar 3, 2026
Merged
Fix clang-tidy readability-identifier-naming violations#381greenc-FNAL merged 2 commits intomaintenance/clang-tidy-namingfrom
clang-tidy readability-identifier-naming violations#381greenc-FNAL merged 2 commits intomaintenance/clang-tidy-namingfrom
Conversation
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix clang-tidy-flagged naming issues
Fix Mar 3, 2026
clang-tidy readability-identifier-naming violations
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on resolving clang-tidy readability-identifier-naming issues by renaming identifiers (notably to avoid parameter/type alias shadowing) in Phlex’s core registration plumbing.
Changes:
- Renamed the
registrarconstructor parameter fromnodestonode_mapto avoidnodes& nodesshadowing the nestedusing nodes = ...alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames identifiers across core graph node and registration code to satisfy the repository's
readability-identifier-namingclang-tidy rules (lowercase for most identifiers, CamelCase for template parameters).Changes
declared_fold.hpp:r→result_type(type alias); expandusing result_type = std::decay_t<...>per reviewer suggestion; fix incomplete rename that leftmake_type_ids<r>()andstd::unique_ptr<r>referencing an undeclared typesimple_ptr_map.hpp: Renametry_emplaceparameterptr→node_ptrto eliminateptr ptrshadowing of the nested type aliasregistrar.hpp: Rename constructor parameternodes→node_mapto eliminatenodes& nodesshadowing of the nested type aliasN/M→num_inputs/num_outputs(single-letter names were flagged as too short and unclear)CMakeLists.txt: RemoveENABLE_CLANG_TIDYoption; updateCLANG_TIDY_CONFIGURATION.mdto reflect direct use ofCMAKE_CXX_CLANG_TIDYExample: parameter shadowing fixes
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.