Change output_products(...) to output_product_suffixes(...)

[knoepfel]

Includes other renaming for consistency purposes.

Resolves #446

[greenc-FNAL]

Review the full CodeQL report for details.

[codecov]

Codecov Report

❌ Patch coverage is 94.62366% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
phlex/core/edge_creation_policy.hpp	80.00%	0 Missing and 1 partial ⚠️
phlex/core/edge_maker.cpp	75.00%	1 Missing ⚠️
phlex/core/message.cpp	66.66%	1 Missing ⚠️
phlex/model/product_specification.cpp	85.71%	0 Missing and 1 partial ⚠️
plugins/python/src/modulewrap.cpp	92.85%	0 Missing and 1 partial ⚠️

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   84.90%   84.94%   +0.03%     
==========================================
  Files         127      127              
  Lines        3339     3340       +1     
  Branches      575      575              
==========================================
+ Hits         2835     2837       +2     
  Misses        308      308              
+ Partials      196      195       -1     

Flag	Coverage Δ
unittests	84.94% <94.62%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
form/form_module.cpp	89.13% <100.00%> (ø)
phlex/core/declared_fold.hpp	95.31% <100.00%> (ø)
phlex/core/declared_observer.hpp	100.00% <100.00%> (ø)
phlex/core/declared_predicate.hpp	94.73% <100.00%> (ø)
phlex/core/declared_transform.hpp	88.57% <100.00%> (ø)
phlex/core/declared_unfold.cpp	83.33% <100.00%> (ø)
phlex/core/declared_unfold.hpp	96.42% <100.00%> (ø)
phlex/core/detail/filter_impl.cpp	95.23% <100.00%> (ø)
phlex/core/detail/filter_impl.hpp	100.00% <ø> (ø)
phlex/core/edge_maker.hpp	100.00% <ø> (ø)
... and 19 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547c196...14bf5dc. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcpaterno]

In phlex/core/edge_maker.hpp, there is a definition of product_name_t (line 26) that seems to be a leftover.

Everything else looks fine to me.

[knoepfel]

In phlex/core/edge_maker.hpp, there is a definition of product_name_t (line 26) that seems to be a leftover.

Everything else looks fine to me.

Thanks, @marcpaterno. I've removed the straggler.