clang-tidy: resolve bugprone-random-generator-seed#490
Merged
Conversation
- Use of `srand()` is intentional for predictability.
2c33f9f to
f18755b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a clang-tidy bugprone-random-generator-seed warning in a test by adding an in-line suppression and documenting outstanding clang-tidy items in a new monthly report.
Changes:
- Add a
NOLINT(bugprone-random-generator-seed)suppression to thesrand(time(0))call intest/form/writer.cpp. - Add a new developer document tracking
clang-tidywarning counts for April 2026.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/form/writer.cpp |
Adds commentary + clang-tidy suppression for srand(time(0)). |
docs/dev/clang-tidy-fixes-2026-04.md |
Introduces an April 2026 clang-tidy fixes tracking checklist. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 85.58% 85.47% -0.12%
==========================================
Files 142 142
Lines 3586 3586
Branches 615 615
==========================================
- Hits 3069 3065 -4
Misses 311 311
- Partials 206 210 +4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
bugprone-random-generator-seed clang-tidy warningclang-tidy: resolve bugprone-random-generator-seed
knoepfel
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppresses the
bugprone-random-generator-seedwarning on the intentionalsrand(std::time(nullptr))call intest/form/writer.cpp, and tracks the fix in the April 2026clang-tidyprogress report.Changes
test/form/writer.cpp: Add// NOLINT(bugprone-random-generator-seed)inline suppression; add explicit<ctime>include; usestd::time(nullptr)instead oftime(0).docs/dev/clang-tidy-fixes-2026-04.md: New monthly report tracking outstandingclang-tidywarnings withbugprone-random-generator-seedmarked as resolved ([x]).