clang-tidy: resolve bugprone-random-generator-seed

docs/dev/clang-tidy-fixes-2026-04.md

@@ -0,0 +1,15 @@
+# `clang-tidy` fixes report
+
+1. `bugprone-*`
+
+   - [ ] bugprone-easily-swappable-parameters (41)
+   - [ ] bugprone-exception-escape (3)
+   - [ ] bugprone-implicit-widening-of-multiplication-result (11)
+   - [ ] bugprone-macro-parentheses (398)
+   - [ ] bugprone-multi-level-implicit-pointer-conversion (4)
+   - [ ] bugprone-narrowing-conversions (34)
+   - [x] [bugprone-random-generator-seed](https://github.com/Framework-R-D/phlex/pull/490) (1)
+   - [ ] bugprone-reserved-identifier (1)
+   - [ ] bugprone-return-const-ref-from-parameter (163)
+   - [ ] bugprone-throwing-static-initialization (11)
+   - [ ] bugprone-unchecked-optional-access (15)

test/form/writer.cpp

@@ -7,6 +7,7 @@
 #include "toy_tracker.hpp"
 
 #include <cstdlib>
+#include <ctime>
 #include <fstream>
 #include <iomanip>
 #include <iostream>
@@ -34,7 +35,8 @@ void generate(std::vector<float>& vrand, int size)
 int main(int argc, char** argv)
 {
   std::cout << "In main" << std::endl;
-  srand(time(0));
+  // Deliberately use C-style random number generation for simplicity in a test
+  srand(time(nullptr)); // NOLINT(bugprone-random-generator-seed)
 
   std::string const filename = (argc > 1) ? argv[1] : "toy.root";
   std::string const checksum_filename = (argc > 2) ? argv[2] : "toy_checksums.txt";