-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cross-fetch version #1113
fix: cross-fetch version #1113
Conversation
Coverage report
Test suite run success1074 tests passing in 184 suites. Report generated by 🧪jest coverage report action from eba36fb |
0652599
to
11a4d9a
Compare
This PR is published in NPM with version 0.0.0-pr-1113-20230725000501 |
CI was not passing; hitting "update branch" appears to have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move the override to some packages/*/package.json
instead of having it globally set on the root package.json
?
I wonder what package uses such an outdated cross-fetch
version from before Oct 5, 2020.
graphql-request latest uses it. |
Good find! Indeed, they're using this outdated version, there's this issue about it. For now, we could still move the overriding inside the Congrats on this hotfix, @LuizAsFight! |
https://pnpm.io/package_json#pnpmoverrides
|
cross-fetch 3.1.8 is breaking when using chrome extension executing requests inside service worker
overriding it to 4.0.0 fixed the problem
ref: cross-fetch