Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross-fetch version #1113

Merged
merged 6 commits into from
Jul 25, 2023
Merged

fix: cross-fetch version #1113

merged 6 commits into from
Jul 25, 2023

Conversation

LuizAsFight
Copy link
Contributor

@LuizAsFight LuizAsFight commented Jul 21, 2023

cross-fetch 3.1.8 is breaking when using chrome extension executing requests inside service worker

overriding it to 4.0.0 fixed the problem

ref: cross-fetch

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 84.48% 4721/5588
🟡 Branches 62.85% 636/1012
🟡 Functions 68.68% 752/1095
🟢 Lines 84.61% 4526/5349

Test suite run success

1074 tests passing in 184 suites.

Report generated by 🧪jest coverage report action from eba36fb

@LuizAsFight LuizAsFight force-pushed the lf/fix/cross-fetch-version branch from 0652599 to 11a4d9a Compare July 21, 2023 04:08
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

This PR is published in NPM with version 0.0.0-pr-1113-20230725000501

@arboleya
Copy link
Member

CI was not passing; hitting "update branch" appears to have fixed it.

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move the override to some packages/*/package.json instead of having it globally set on the root package.json?

I wonder what package uses such an outdated cross-fetch version from before Oct 5, 2020.

@LuizAsFight
Copy link
Contributor Author

Would it be possible to move the override to some packages/*/package.json instead of having it globally set on the root package.json?

I wonder what package uses such an outdated cross-fetch version from before Oct 5, 2020.

graphql-request latest uses it.

@arboleya
Copy link
Member

Good find! Indeed, they're using this outdated version, there's this issue about it.

For now, we could still move the overriding inside the provider package.

Congrats on this hotfix, @LuizAsFight!

@LuizAsFight
Copy link
Contributor Author

@arboleya

https://pnpm.io/package_json#pnpmoverrides

Note that the overrides field can only be set at the root of the project.

@LuizAsFight LuizAsFight marked this pull request as ready for review July 25, 2023 00:12
@LuizAsFight LuizAsFight requested a review from arboleya July 25, 2023 00:12
@LuizAsFight LuizAsFight enabled auto-merge (squash) July 25, 2023 00:47
@arboleya arboleya disabled auto-merge July 25, 2023 00:58
@arboleya arboleya enabled auto-merge (squash) July 25, 2023 01:03
@arboleya arboleya merged commit 542c5f7 into master Jul 25, 2023
@arboleya arboleya deleted the lf/fix/cross-fetch-version branch July 25, 2023 09:00
nedsalk pushed a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants