Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PRs tagged as breaking must have minor changes #2987

Merged
merged 5 commits into from
Aug 21, 2024
Merged

fix: PRs tagged as breaking must have minor changes #2987

merged 5 commits into from
Aug 21, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Aug 20, 2024 •
edited
Loading

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the chore Issue is a chore label Aug 20, 2024
@nedsalk nedsalk self-assigned this Aug 20, 2024
@github-actions github-actions bot added the bug Issue is a bug label Aug 20, 2024
@nedsalk nedsalk changed the title fix!: PRs tagged with ! must have minor changes fix: PRs tagged with ! must have minor changes Aug 20, 2024
@nedsalk nedsalk marked this pull request as ready for review August 20, 2024 12:35
@nedsalk nedsalk enabled auto-merge (squash) August 20, 2024 12:36
@nedsalk nedsalk changed the title fix: PRs tagged with ! must have minor changes fix: PRs tagged as breaking must have minor changes Aug 20, 2024
danielbate
danielbate approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with nit below 👍🏻

.github/workflows/pr-validate-changesets.yaml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.79%(+0%) 77.82%(+0%) 79.55%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk merged commit 71220b5 into master Aug 21, 2024
20 checks passed
@nedsalk nedsalk deleted the ns/chore/breaking-changes-ci branch August 21, 2024 11:00
maschad pushed a commit that referenced this pull request Aug 21, 2024
@nedsalk @maschad
fix: PRs tagged with ! must have minor changes (#2987)
e057ca0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRs tagged as breaking with ! should have minor changes in changeset
4 participants
@nedsalk @arboleya @danielbate @Torres-ssf