Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PRs tagged as breaking must have minor changes #2987

Merged
merged 5 commits into from
Aug 21, 2024
Merged

fix: PRs tagged as breaking must have minor changes #2987

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f7fdd5
test out
nedsalk Aug 20, 2024
072c1bb
test out minor
nedsalk Aug 20, 2024
196f696
cleanup changeset
nedsalk Aug 20, 2024
deb1766
Update eleven-ties-bathe.md
nedsalk Aug 20, 2024
e8c20c2
Merge branch 'master' into ns/chore/breaking-changes-ci
nedsalk Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/eleven-ties-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

fix: PRs tagged as breaking must have minor changes
12 changes: 12 additions & 0 deletions .github/workflows/pr-validate-changesets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@ jobs:
fi
fi

# Check if the PR title contains an exclamation mark (breaking)
if echo "$PR_TITLE" | grep -q '!'; then
# If the PR is breaking, ensure that the changeset contains minor changes
if ! echo "$AFFECTED_PACKAGES" | grep -q 'minor'; then
nedsalk marked this conversation as resolved.
Show resolved Hide resolved
echo "PR is marked as breaking but changeset does not contain minor changes."
echo "Changeset file: $CHANGESET_FILE"
echo "Changeset content:"
cat "$CHANGESET_FILE"
exit 1
fi
fi

CHANGESET_DESCRIPTION=$(sed 's/^\s*\|\s*$//g' "$CHANGESET_FILE" | tail -n1)

if [ "$CHANGESET_DESCRIPTION" != "$PR_TITLE" ]; then
Expand Down
Loading