Fixing crash in chunk_text for empty file
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
whitead
reviewed
Sep 13, 2024
mskarlin
reviewed
Sep 13, 2024
whitead
approved these changes
Sep 13, 2024
dosubot
bot
added
lgtm
…n to print better
jamesbraza
force-pushed
the
fixing-div0
branch
from
23e1478
to
19835a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
chunk_pdfhandles empty PDFs by raisingImpossibleParsingError, butchunk_textdidn't have the same logic. So this PR ports the logic, and expands tests to cover this edge case