Fixing index error bug with forcenooverlaps#323
Open
tcmcclan-ornl wants to merge 2 commits intoGEOUNED-org:devfrom
Open
Fixing index error bug with forcenooverlaps#323tcmcclan-ornl wants to merge 2 commits intoGEOUNED-org:devfrom
tcmcclan-ornl wants to merge 2 commits intoGEOUNED-org:devfrom
Conversation
psauvan
reviewed
Feb 17, 2026
| comp.clean() | ||
|
|
||
| m.set_definition(new_def) | ||
| for i in range(len(m.Definition.elements)): |
Member
There was a problem hiding this comment.
the index i should be reversed otherwise if there are more than one element to remove, the module pop(i) will not remove the correct element
the line should be :
for i in reversed(range(len(m.Definition.elements))):
psauvan
requested changes
Feb 17, 2026
Member
psauvan
left a comment
psauvan
left a comment
There was a problem hiding this comment.
The line 897 should be corrected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a check for any bool found in the m.Definition.elements list that gets deleted during the m.Definition.join_operators() call in the cell_definition.py file.
Fixes issue
#322
Checklist