Skip to content

Fixing index error bug with forcenooverlaps #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tcmcclan-ornl wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fixing index error bug with forcenooverlaps #323

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7774850
Fixed the index error bug with forcenooverlaps
tcmcclan-ornl May 9, 2025
513a60e
Added the same logic in the BoolSequence clean command
tcmcclan-ornl May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/geouned/GEOUNED/conversion/cell_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,10 @@ def no_overlapping_cell(metaList, surfaces, options):
comp.clean()

m.set_definition(new_def)
for i in range(len(m.Definition.elements)):
Copy link
Member

@psauvan psauvan Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the index i should be reversed otherwise if there are more than one element to remove, the module pop(i) will not remove the correct element
the line should be :
for i in reversed(range(len(m.Definition.elements))):

if type(m.Definition.elements[i].elements) is bool:
logger.info(f"Removed a Solid {i} from cell {m.__id__}")
m.Solids.pop(i)
m.Definition.join_operators()
m.Definition.level_update()

Expand Down