Inspector direct editing #6257
Inspector direct editing #6257
Conversation
murraystevenson
force-pushed
the
inspectorColumnDrag
branch
2 times, most recently
from
c952758 to
babefb3
Compare
There was a problem hiding this comment.
Thanks Murray - this is another nice step forwards for the editors. We already chatted a bit about possible refactoring of the Inspector::Result methods so they're a bit more uniform - I've made a few comments in that regard, but I don't know if now is the time to address them. Perhaps you'd find it easier to get this over the line and then revisit? Since it's private I think that would be OK if it helps. Other comments inline as usual...
Cheers...
John
We'll be introducing a new editFunction for making direct edits.
murraystevenson
force-pushed
the
inspectorColumnDrag
branch
from
babefb3 to
cf766b8
Compare
|
Thanks for the input, I've addressed the drag and drop related comments inline but will punt the Inspector API related suggestions to a later PR as it feels like some broader reshuffling is necessary now that we have the required functionality in place... I've added one additional commit on the end which ensures edits on TweakPlugs are made in |
|
Thanks Murray, LGTM! Squash and merge away... |
This simplifies things and allows us to no longer rely on `SetMembershipInspector::editSetMembership()`
This is replaced by Inspector's more generic `edit()` and `canEdit()`
The PathListingWidget is just the intermediary, we expect the column to do the work. Signals are forwarded to the column such that dragEnter and dragLeave are emitted for each index.
This avoids adding new member variables to PathColumn for Gaffer 1.5 and should be reverted on main.
murraystevenson
force-pushed
the
inspectorColumnDrag
branch
from
cf766b8 to
488fd35
Compare
This adds support for "direct" editing to the private Inspector API with new
edit()andcanEdit()methods onInspector::Resultthat allow creating an edit directly from a value and checking whether an edit could be made from a value.This PR includes two usages of this API, one which allows us to simplify the toggling of bool values in
_InspectorColumn(and removeSetMembershipInspector::editSetMembership()in the process). The other brings drag and drop editing to the AttributeEditor, LightEditor and RenderPassEditor.We also plan to use this API to provide copy/paste editing in the same editors in a future PR.