Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

310-continuous-draws-fix #311

Merged
merged 1 commit into from
Jan 14, 2025
Merged

310-continuous-draws-fix #311

merged 1 commit into from
Jan 14, 2025

Conversation

gravesti
Copy link
Collaborator

@gravesti gravesti commented Dec 18, 2024 •
edited
Loading

Fixes #310

  • Don't report exp(treatment effect) for continuous outcomes
  • Fix stan models:
    • remove Z and tau from full/no borrowing model
    • fix Z, alpha, tau definitions in BDB model
  • add effective tests

@gravesti gravesti linked an issue Dec 18, 2024 that may be closed by this pull request
rename_draws_covariates() does not work with continuous outcome #310
Closed
@gravesti gravesti requested a review from mattsecrest January 13, 2025 09:40
mattsecrest
mattsecrest approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@mattsecrest mattsecrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh yeah I guess the continuous endpoints got left behind - likely due to missing test cases. Good catches Isaac and thanks for managing the issues during the break.

@gravesti gravesti merged commit e5422fd into main Jan 14, 2025
5 checks passed
@gravesti gravesti deleted the 310-rename_draws_covariates-does-not-work-with-continuous-outcome branch January 14, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsecrest mattsecrest mattsecrest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename_draws_covariates() does not work with continuous outcome
2 participants
@gravesti @mattsecrest