-
Notifications
You must be signed in to change notification settings - Fork 302
Improve testing coverage #5941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aleksandar-apostolov
merged 12 commits into
develop
from
AND-744-increase-testing-code-coverage-of-ui-common-module
Oct 6, 2025
Merged
Improve testing coverage #5941
aleksandar-apostolov
merged 12 commits into
develop
from
AND-744-increase-testing-code-coverage-of-ui-common-module
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
3c95907
to
7e47122
Compare
7e47122
to
a47ca66
Compare
VelikovPetar
reviewed
Oct 2, 2025
...java/io/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewActivity.kt
Outdated
Show resolved
Hide resolved
.../test/kotlin/io/getstream/chat/android/ui/common/feature/threads/ThreadListControllerTest.kt
Show resolved
Hide resolved
VelikovPetar
approved these changes
Oct 2, 2025
…sponding unit test
67a6ec9
to
ce5e885
Compare
ui-common
module…-ui-common-module
|
aleksandar-apostolov
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧪 Testing
Some of the changes here modified components to be testable. Those changes should not impact any functionality.
However, it is worth testing the functionality of
DefaultStreamMediaRecorder
to ensure that no regression issues are introduced. Test sending an audio record from the message composer of both XML and Compose SDKs.