chore: update ESLint, migrate configuration file #2574
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
oliverlaz,
myandrienko and
MartinCupela
and removed request for
oliverlaz and
myandrienko
|
Size Change: -475 B (-0.04%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
0fb487d to
4505339
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
==========================================
+ Coverage 82.95% 82.97% +0.02%
==========================================
Files 444 444
Lines 9222 9234 +12
Branches 2254 2251 -3
==========================================
+ Hits 7650 7662 +12
- Misses 1239 1240 +1
+ Partials 333 332 -1 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
7e4ce05 to
e0dfe4d
Compare
oliverlaz
approved these changes
Dec 9, 2024
| @@ -27,7 +27,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node: [16, 18] | |||
| node: [18, 20] | |||
There was a problem hiding this comment.
Do we have a good reason to run tests with two different node versions? If not, I think we can directly go to v22 (latest LTS).
Comment on lines
-226
to
-246
| "eslint": "7.14.0", | ||
| "eslint-config-airbnb": "^18.2.1", | ||
| "eslint-config-prettier": "^6.15.0", | ||
| "eslint-config-react-app": "^6.0.0", | ||
| "eslint-import-resolver-alias": "^1.1.2", | ||
| "eslint-import-resolver-babel-module": "^5.2.0", | ||
| "eslint-plugin-babel": "^5.3.1", | ||
| "eslint-plugin-flowtype": "^5.2.0", | ||
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-jest": "^24.1.3", | ||
| "eslint-plugin-jest-dom": "^3.3.0", | ||
| "eslint-plugin-jsx-a11y": "^6.4.1", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^3.1.4", | ||
| "eslint-plugin-promise": "^4.2.1", | ||
| "eslint-plugin-react": "^7.21.5", | ||
| "eslint-plugin-react-hooks": "^4.2.0", | ||
| "eslint-plugin-sort-destructure-keys": "1.3.5", | ||
| "eslint-plugin-sort-keys-fix": "^1.1.2", | ||
| "eslint-plugin-testing-library": "^6.2.0", | ||
| "eslint-plugin-typescript-sort-keys": "^2.1.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Time to UPGRADE and migrate. :)
PR is divided into two commits, ESLint changes and Prettier changes - we can drop Prettier changes for
mastermerges (so that I don't have to deal with merge conflicts) and merge this PR once our PR backlog is somewhat empty.