Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ESLint, migrate configuration file #2574

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .eslintignore

This file was deleted.

230 changes: 0 additions & 230 deletions .eslintrc.json

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16, 18]
node: [18, 20]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a good reason to run tests with two different node versions? If not, I think we can directly go to v22 (latest LTS).

name: Test with Node ${{ matrix.node }}
steps:
- uses: actions/checkout@v3
Expand Down
8 changes: 5 additions & 3 deletions .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@
}
],
[
"@semantic-release/exec", {
"prepareCmd": "NEXT_VERSION=${nextRelease.version} npm run build"
}],
"@semantic-release/exec",
{
"prepareCmd": "NEXT_VERSION=${nextRelease.version} npm run build"
}
],
[
"@semantic-release/changelog",
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,4 @@
"troubleshooting/troubleshooting",
"resources/resources"
]
}
}
5 changes: 1 addition & 4 deletions docusaurus/react_versions.json
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
[
"11.x.x",
"11.x.x-legacy"
]
["11.x.x", "11.x.x-legacy"]
2 changes: 1 addition & 1 deletion e2e/fixtures/data/attachment.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable sort-keys */
const smallImageAttachment = [
{
type: 'image',
Expand Down
5 changes: 4 additions & 1 deletion e2e/user/Controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import type { Page } from '@playwright/test';
import selectors from './selectors';

export class Controller {
constructor(private baseURL: string | undefined, private page: Page) {}
constructor(
private baseURL: string | undefined,
private page: Page,
) {}

async openStory(story: string, waitForPresence: string) {
await Promise.all([
Expand Down
2 changes: 1 addition & 1 deletion e2e/user/components/Attachment/Attachment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { expect, Page } from '@playwright/test';

const attachmentTypes = ['card', 'img', 'gallery', 'video', 'file', 'media'] as const;

type AttachmentType = typeof attachmentTypes[number];
type AttachmentType = (typeof attachmentTypes)[number];

export function getAttachment(page: Page, type: AttachmentType) {
return page.locator(`.str-chat__message-attachment--${type}`);
Expand Down
Loading
Loading