chore: update ESLint, migrate configuration file #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
oliverlaz,
myandrienko and
MartinCupela
and removed request for
oliverlaz and
myandrienko
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
0fb487d to
4505339
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
==========================================
- Coverage 81.06% 80.84% -0.22%
==========================================
Files 450 450
Lines 9505 9631 +126
Branches 2233 2297 +64
==========================================
+ Hits 7705 7786 +81
- Misses 1684 1725 +41
- Partials 116 120 +4 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
7e4ce05 to
e0dfe4d
Compare
oliverlaz
approved these changes
Dec 9, 2024
arnautov-anton
force-pushed
the
chore/update-eslint
branch
9 times, most recently
from
d037191 to
82edfc7
Compare
arnautov-anton
force-pushed
the
chore/update-eslint
branch
2 times, most recently
from
1efe134 to
2b07024
Compare
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
e5b25cf to
35305f3
Compare
arnautov-anton
force-pushed
the
chore/update-eslint
branch
2 times, most recently
from
5135cd0 to
81fbb69
Compare
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
374f117 to
67a302f
Compare
MartinCupela
approved these changes
Jan 31, 2025
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
67a302f to
c1d7b70
Compare
arnautov-anton
force-pushed
the
chore/update-eslint
branch
from
c1d7b70 to
616e877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Time to UPGRADE and migrate. :)
PR is divided into multiple commits, ESLint changes, Prettier changes and manual changes - we can drop Prettier changes for
mastermerges (so that I don't have to deal with merge conflicts) and merge this PR once our PR backlog is somewhat empty.Notable Changes
bundle-cjs.mjsandgetPackageVersion.mjsto use import forpackage.jsoninstead (withassertion)eslint-plugin-prettieras Prettier format step is included in CI anyway@testing-library/domas it's required by our tests and is no longer installed witheslint-plugin-jest-domnoUnusedParametersandnoUnusedLocals(tsconfig.json) are now set tofalseto not fail build steps, developers are still warned through ESLint