network: miscellaneous changes #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
force-pushed
the
thiagowfx/network
branch
19 times, most recently
from
0737f64 to
e616703
Compare
thiagowfx
force-pushed
the
thiagowfx/network
branch
from
e616703 to
bf2faf0
Compare
|
Will regenerate WPT expectations. |
thiagowfx
force-pushed
the
thiagowfx/network
branch
4 times, most recently
from
26c0df9 to
a33174a
Compare
|
I believe there's a race condition in the current implementation. |
thiagowfx
force-pushed
the
thiagowfx/network
branch
from
d000b8d to
dd8c6bf
Compare
thiagowfx
force-pushed
the
thiagowfx/network
branch
2 times, most recently
from
1782c67 to
61f8cad
Compare
auto-merge was automatically disabled
May 25, 2023 14:37
Pull request was closed
Verified it matches the CDP/DevTools implementation:
cached(): boolean {
return (Boolean(this.#fromMemoryCache) || Boolean(this.#fromDiskCache)) && !this.#transferSizeInternal;
}
thiagowfx
force-pushed
the
thiagowfx/network
branch
from
6f37172 to
def16a2
Compare
thiagowfx
force-pushed
the
thiagowfx/network
branch
from
def16a2 to
eefa77c
Compare
...driver/headless/webdriver/tests/bidi/network/response_started/response_started_cached.py.ini
Show resolved
Hide resolved
sadym-chromium
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit history for changes.
Bug: #765
Spec: https://w3c.github.io/webdriver-bidi/#module-network