-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(genai): add batch prediction samples (2) #10190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add batch prediction samples (2) #10190
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Generative AI samples by adding a new example for batch prediction that leverages BigQuery. The primary goal is to provide developers with a clear, runnable code sample for setting up and monitoring GenAI batch jobs where data is sourced from and results are written to BigQuery, ensuring robust integration and functionality through dedicated testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new sample for batch prediction using BigQuery as a source and destination. The code is well-structured and includes a corresponding integration test. I have a couple of suggestions to improve the sample's usability and robustness. Specifically, I recommend making the location configurable and strengthening the polling logic to handle cases where a job state might be missing.
genai/snippets/src/main/java/genai/batchprediction/BatchPredictionWithBq.java
Show resolved
Hide resolved
genai/snippets/src/main/java/genai/batchprediction/BatchPredictionWithBq.java
Outdated
Show resolved
Hide resolved
|
@jdomingr - Please fix the file conflicts |
Description
Add new batch prediction with BigQuery sample.
Checklist
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only