Handle GKE 1.12 node_config.metadata default value #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm the modular magician, I work on Magic Modules. Pull request statusesNo diff detected in terraform-google-conversion. New Pull RequestsI built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
chrisst
approved these changes
Mar 13, 2019
| @@ -61,6 +61,10 @@ resource "google_container_node_pool" "primary_preemptible_nodes" { | |||
| preemptible = true | |||
| machine_type = "n1-standard-1" | |||
|
|
|||
| metadata { | |||
| disable-legacy-endpoints = "true" | |||
There was a problem hiding this comment.
I assume this means the api is expecting a boolean jammed in a string? In which case :(
There was a problem hiding this comment.
This is JSON so there are no rules :)
…xamples, add warning to docs
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
gke-legacy-endpoints
branch
from
9794478 to
7d0842a
Compare
This was referenced May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE
1.12added a default metadata value causing diffs in user configs. This is a security improvement, and only affects new cluster creation so this is a change we want to pick up. Terraform doesn't let us define default values forTypeMaps, so this needs to beComputed.Fixes hashicorp/terraform-provider-google#3230 and also some integration tests that have been failing.
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]