This repository was archived by the owner on Oct 27, 2022. It is now read-only.
follow go style of table-driven tests more closesly #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tritone
reviewed
Aug 23, 2020
internal/lifecycle/readme_test.go
Outdated
| if len(tc.codeBlock) == 0 { | ||
| continue | ||
| } | ||
| t.Run(fmt.Sprintf("#%d", i), func(t *testing.T) { |
There was a problem hiding this comment.
Instead of just giving a number here, your first arg to T.Run should be a test case description. Add a name field to toCommandsTest and fill that with a brief description, replacing the comments that you have added to each case. That way when there's a failure it's clear from the output which test case failed.
There was a problem hiding this comment.
Resolved, thank you. Does the updated version have the description format you were looking for?
|
Also uncommenting a test case that was originally commented out, addressed by #29. |
tritone
approved these changes
Aug 28, 2020
internal/lifecycle/readme_test.go
Outdated
| }, | ||
| cmds: []*exec.Cmd{ | ||
| exec.Command("echo", "hello", "world"), | ||
| exec.Command("echo", "hello", "wosrld"), |
internal/lifecycle/readme_test.go
Outdated
| var toCommandsTests = []toCommandsTest{ | ||
| // single one-line command | ||
| { | ||
| description: "single one-line command test", |
There was a problem hiding this comment.
You can leave "test" off the end of all of these.
tritone
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to: #25 (comment)
Use
T.Runfor creating subtests for each test case.