fix(tpg v5)!: rule.rate_limit_options.enforce_on_key has not default value

[imrannayer]

In 4.X, the default value for rule.rate_limit_options.enforce_on_key is ALL. In 5.X this field no longer has a default value. If you need All you will need to set it explicitly. See Rule 2 in examples/security-policy-all folder for reference.

[g-awmalik]

Couple of minor nits.

[g-awmalik]

Do we need versions.tf for examples?

[apeabody]

Infrequently, might be needed if the example make use a provider directly such as Random, etc.

[imrannayer]

Since we dont have any other provider except google, leme remove it.

[apeabody]

Thanks @imrannayer! Can you also lift to 6 in https://github.com/GoogleCloudPlatform/terraform-google-cloud-armor/blob/main/test/setup/versions.tf

[imrannayer]

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

[apeabody]

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

[imrannayer]

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

@apeabody #70 is already a breaking change. I think it will be better to release 5.X with it.

[apeabody]

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

@apeabody #70 is already a breaking change. I think it will be better to release 5.X with it.

Just to confirm, the breaking change rule.rate_limit_options.enforce_on_key will also raise the minimum TPG to >= 5?

[imrannayer]

@apeabody I am not changing min version to 5.X. Min is still 4.79. But in case anyone gets upgrade to 5.X will need to make sure they provide a value for rule.rate_limit_options.enforce_on_key.

[apeabody]

@apeabody I am not changing min version to 5.X. Min is still 4.79. But in case anyone gets upgrade to 5.X will need to make sure they provide a value for rule.rate_limit_options.enforce_on_key.

Got it - Thanks!

[imrannayer]

/gcbrun

[imrannayer]

@g-awmalik can u plz approve this PR