Fix build on MacOS #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately macfuse chose to change the signature of getxattr. This is a bit annoying, but we can work around it by adding a new function that translates the arguments to the right signature. We assume that the `position` argument is safe to be ignored.
Gottox
force-pushed
the
fix/macos-build
branch
from
884668f
to
5836e07
Compare
According to [1] macfuse is hard to be used inside of github actions. This commit modifies the test suite to not test sqshfs2 if the host system is darwin. [1] #77 (comment)
Gottox
force-pushed
the
fix/macos-build
branch
from
5836e07
to
879b8e7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.