Make safe the functions of the "fit" module #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
fit::linear
,... were not checking that the lengthn
was not too large (in which case the function would access memory outside the slice 😨). This PR fixes that.P.S. IMHO, the strides and length parameters should be optional. For example a trait for “slice or (slice, stride)” would be simple and convenient (for strides, not the length
n
). For a better “Rust like” user experience, bigger changes are needed (I can try to propose something if you agree that such a change is beneficial).