Social icons animation in footer & "email required" message bug fixed. #840
Conversation
The email input tag showing "email required" prior to writing email has been fixed .
added colors on hover in social icons in footer ie. instagram, twitter, youtube. also added the place-holder color to fade a bit on focus in the email input box.
|
Thank you and congrats🎉 for opening this pull request!💖 Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀 |
thevirengarg
requested review from
thevirengarg,
Kajol-Kumari and
Aditi-Dahiya
|
so basically we have to remove " * Please enter valid Email " message , |
| @@ -23,7 +23,7 @@ export const Footer = (props) => { | |||
| isValid = false; | |||
| } | |||
| if (!email.trim()) { | |||
| emailErr.emailRequired = "* Email is required"; | |||
There was a problem hiding this comment.
retain this. This is an expected error message
There was a problem hiding this comment.
yeah i will do that. But what to do with the " enter valid email " message . should i remove it or retain it. @Kajol-Kumari
| .fa-envelope:hover, | ||
| .fa-envelope-own:hover { | ||
| color: #c71610; | ||
| .fa-instagram:hover, |
There was a problem hiding this comment.
any specific reason of modfying the css? Why do we need to change these hover effects?
There was a problem hiding this comment.
can you pls update me with whats the use of this envelope tag in the code. thanks @Kajol-Kumari
There was a problem hiding this comment.
Its a favicon icon, so the icons u see on the footer for instagram is fa-instagram
placed the envelope tag in its place .(as requested)
retained the "email is required" message in the email form.
|
@Kajol-Kumari @thevirengarg pls reply to these changes, IWOC is ending soon. |
|
Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌 |
Issue that this pull request solves
Closes: #828 Footer Email Input Validation Message Appears Unnecessarily When Input is Not Provided; Social media icons fails animation on hover IWOC
Proposed changes
Footer Email Input Validation:
When the email input box in the footer is active, the validation message indicating "email required" was appearing even when no input is provided. This has been fixed now, it doesn't show this message unnecessarily.
Social Media Icons Animation:
Previously on hovering over the social media icons in the footer, instagram , twitter , youtube failed to display the expected animation. I have added the particular animation to them.
Placeholder of email input:
The placeholder remained the same dark colored even on focus if the input .
I have added a light grey color to make is more pleasing to user.
Brief description of what is fixed or changed
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Other information
Any other information that is important to this pull request