Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social icons animation in footer & "email required" message bug fixed. #840

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Social icons animation in footer & "email required" message bug fixed. #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
050ce13
"email-required" message in footer removed
adi-exe Jan 26, 2024
f0ce27d
leftover added animations to the social icons in footer.
adi-exe Jan 26, 2024
3f64f02
Update footer.module.scss
adi-exe Jan 31, 2024
f96692f
retained the "email is required" message Footer.jsx
adi-exe Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ export const Footer = (props) => {
<ul className={dark ? style["nav-ul-dark"] : style["nav-ul"]}>
<li>Be sure to give us a follow on the below social links</li>
</ul>

<div className={`col ${style["col"]}`}>
<ul className={dark ? style["social-dark"] : style["social"]}>
<li>
Expand Down
24 changes: 24 additions & 0 deletions frontend/src/components/Footer/footer.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,16 +207,32 @@
color: #dd2a7b;
}


.fa-envelope:hover,
.fa-envelope-own:hover {
color: #c71610;
}

.fa-instagram:hover,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason of modfying the css? Why do we need to change these hover effects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls update me with whats the use of this envelope tag in the code. thanks @Kajol-Kumari

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a favicon icon, so the icons u see on the footer for instagram is fa-instagram

.fa-instagram-own:hover {
color: #f77737;
}

.fa-github:hover,
.fa-github-own:hover {
color: #7af7cd;
}

.fa-twitter:hover,
.fa-twitter-own:hover {
color: #1da1f2;
}

.fa-youtube:hover,
.fa-youtube-own:hover {
color: #ff0000;
}

.footer-dash {
text-align: center;
padding-top: 2px;
Expand Down Expand Up @@ -572,6 +588,14 @@ a > span {
color: #fff;
}

.input-field-footer::placeholder {
color: #555555;
}

.input-field-footer:focus::placeholder {
color: #999999;
}

.validation {
color: red;
margin-top: 0;
Expand Down
Loading