Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent sign waiver from showing when user is confirmed and properly update vertical timeline #254

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix: prevent sign waiver from showing when user is confirmed and properly update vertical timeline #254

merged 3 commits into from
Jan 17, 2024

Conversation

waalbert
Copy link
Member

Resolves #253

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 958bd2f

@waalbert waalbert requested a review from a team January 17, 2024 05:18
samderanova
samderanova approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the conditionals and fixing the issue.

taesungh
taesungh approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@waalbert waalbert merged commit d3ac971 into main Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Portal] Sign Waiver shown when confirmed and Vertical Timeline not updated
3 participants
@waalbert @samderanova @taesungh