Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent sign waiver from showing when user is confirmed and properly update vertical timeline #254

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix: prevent sign waiver from showing when user is confirmed and properly update vertical timeline #254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b679f
fix: prevent sign waiver from showing when user is confirmed and prop…
waalbert Jan 17, 2024
122b1a8
chore: clean up conditionals
waalbert Jan 17, 2024
958bd2f
chore: clean up conditional
waalbert Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/site/src/app/(main)/portal/@applicant/SignWaiver.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ interface SignWaiverProps {
}

function SignWaiver({ status }: SignWaiverProps) {
return status === PortalStatus.waived ? null : (
return status === PortalStatus.waived ||
status === PortalStatus.confirmed ? null : (
<div>
<hr />
<h3 className="text-3xl my-4">Waiver</h3>
Expand Down
2 changes: 1 addition & 1 deletion apps/site/src/app/(main)/portal/@applicant/VerticalTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function VerticalTimeline({ status }: VerticalTimelineProps) {
) : null;

const rsvp_component =
status === PortalStatus.accepted || PortalStatus.waived ? (
status === PortalStatus.accepted || status === PortalStatus.waived ? (
<li className="flex flex-row items-center border-t">
<Image
src={BorderCircle}
Expand Down