Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate waitlist promotion modal and action #346

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Jan 24, 2024

Finishes the remaining of #340.

Changes

  • Create new promote action that shows modal with confirmation button and instructions to participant
  • Show promote action instead of check in for waitlisted participants
  • Disable promote action for organizers who are not check-in leads, showing PopOver message
  • Disable check in action for participants with WAIVER_SIGNED status, showing PopOver message

Testing

  1. Impersonate yourself and navigate to the participants page of the admin dashboard. Make sure to grant yourself the director role!
  2. If they don't already exist, create records of users with the ATTENDING, WAIVER_SIGNED, WAITLISTED, and ACCEPTED statuses.
  3. Click "Check In" and ensure the modal has popped up. Then click "Confirmed". A new check-in record should show up in the database.
  4. Ensure that you do not have access to click "Promote" and that when clicking on it, a tooltip shows up explaining why.
  5. Now grant your UID the role of checkin_lead to allow yourself to check in people and promote applicants off the waitlist.
  6. Click "Promote". The API call should return a 500 status code because this route updates the applicant's status to ACCEPTED and then attempts to send out an email to the applicant notifying them of their acceptance, but you do not have the API key for that.

- Create new promote action that shows modal with confirmation button
  and instructions to participant
- Show promote action instead of check in for waitlisted participants
- Disable promote action for organizers who are not check-in leads,
  showing PopOver message
- Disable check in action for participants with `WAIVER_SIGNED` status,
  showing PopOver message
@samderanova samderanova requested review from taesungh and a team January 24, 2024 10:30
@samderanova samderanova linked an issue Jan 24, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 3bc0aa2

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring out how to work with the modal and hook. One typo on state setter and one issue on authorization besides smaller nitpicks.

@taesungh taesungh changed the title Feature/pms waitlist system Integrate waitlist promotion modal and action Jan 24, 2024
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all of the issues. I'll figure out a way to incorporate mutations as part of #344.

@samderanova samderanova merged commit b3784fe into main Jan 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PMS] Incorporate waitlist promotion system into Participants page
2 participants