-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate waitlist promotion modal and action #346
Conversation
- Create new promote action that shows modal with confirmation button and instructions to participant - Show promote action instead of check in for waitlisted participants - Disable promote action for organizers who are not check-in leads, showing PopOver message - Disable check in action for participants with `WAIVER_SIGNED` status, showing PopOver message
Deploy preview for irvinehacks-site-2024 ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work figuring out how to work with the modal and hook. One typo on state setter and one issue on authorization besides smaller nitpicks.
apps/site/src/app/admin/participants/components/ParticipantAction.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantAction.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantAction.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Taesung Hwang <[email protected]>
Co-authored-by: Taesung Hwang <[email protected]>
…vinehacks-site-2024 into feature/pms-waitlist-system
apps/site/src/app/admin/participants/components/ParticipantActionPopver.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantAction.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantAction.tsx
Outdated
Show resolved
Hide resolved
f0aef31
to
5fbc3b5
Compare
5fbc3b5
to
afa8185
Compare
ec8caec
to
3bc0aa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all of the issues. I'll figure out a way to incorporate mutations as part of #344.
Finishes the remaining of #340.
Changes
WAIVER_SIGNED
status, showing PopOver messageTesting
ATTENDING
,WAIVER_SIGNED
,WAITLISTED
, andACCEPTED
statuses.checkin_lead
to allow yourself to check in people and promote applicants off the waitlist.ACCEPTED
and then attempts to send out an email to the applicant notifying them of their acceptance, but you do not have the API key for that.