-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering by text/role/status, sorting, pagination, collection prefs #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efs via collection hooks
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
alanchangxyz
commented
Jan 26, 2024
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
taesungh
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for offering to work on this. One type issue, one deprecation warning, one note about multiselect, and other minor suggestions about display and refactoring.
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
Deploy preview for irvinehacks-site-2024 ready!
|
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsFilters.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/participants/components/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
samderanova
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using collection hooks
Resolves #269
Changes
useCollection()
hookSelect
menus added to filter by participant role & status;TextFilter
box now also works to search by substrings in UID/name (no email/badge # for now, data not inParticipant
type)