Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore missing transparent section of background art #37

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: restore missing transparent section of background art #37

merged 3 commits into from
Nov 27, 2023

Conversation

samderanova
Copy link
Contributor

Resolves #36 by replacing the landing background JPG with its corresponding PNG version.

@samderanova samderanova linked an issue Nov 25, 2023 that may be closed by this pull request
Hotfix: Landing JPG vs PNG #36
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 4eaed80

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 4eaed80

@samderanova samderanova mentioned this pull request Nov 25, 2023
Merged
taesungh
taesungh reviewed Nov 26, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the increased asset size. Could we explore a hybrid masking approach using a lossy-compressed background art with a separate alpha mask?

@taesungh
Use separate mask for landing background
56c6d88 
- To reduce asset size, compress the background JPEG and use a
  separate smaller transparent PNG as a `mask-image`
- This will become irrelevant once the layers are separated for a
  dynamic floating design
@taesungh taesungh changed the title fix: restore landing background png fix: restore missing transparent section of background art Nov 26, 2023
samderanova
samderanova commented Nov 26, 2023
View reviewed changes
Copy link
Contributor Author

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the mask! One quick question:

apps/site/src/assets/backgrounds/landing-background.jpg Show resolved Hide resolved
taesungh
taesungh approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now. Let's not wallow in this too much since we'll eventually have the more fluid design from #30.

@taesungh taesungh linked an issue Nov 27, 2023 that may be closed by this pull request
Use JPG + Alpha Masking for Landing Background instead of PNG #39
Closed
@taesungh taesungh merged commit 8277cd1 into main Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use JPG + Alpha Masking for Landing Background instead of PNG Hotfix: Landing JPG vs PNG
2 participants
@samderanova @taesungh