Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to run checks for the API and site #64

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

taesungh
Copy link
Member

As we did before with last year's HackUCI-Site repository, we can use a GitHub Actions workflow to run checks on pull requests and pushes to main.

The checks run for this pull request will initially fail because there is a type error in saml.py which will demonstrate that this runner works.

Changes

  • Include Python dev dependencies for checks runner
  • Configure Python linting tools and provide compatible VS Code settings
  • Update production deployment to run only when checks succeed

- Include Python dev dependencies for checks runner
- Configure Python linting tools and provide compatible VS Code settings
- Update production deployment to run only when checks succeed
Copy link
Contributor

github-actions bot commented Dec 10, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit ceb82ff

Copy link
Contributor

github-actions bot commented Dec 10, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit ceb82ff

@taesungh
Copy link
Member Author

Update: the relevant SAML is not spotted during pull request since those lines were not changed but would be caught if we merged and pushed to main. Will try adding some files with errors on purpose to demonstrate the concept.

apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/src/routers/demo.py Outdated Show resolved Hide resolved
apps/api/tests/test_demo.py Outdated Show resolved Hide resolved
samderanova
samderanova previously approved these changes Dec 10, 2023
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for working on this. One small question:

apps/api/setup.cfg Show resolved Hide resolved
@samderanova
Copy link
Contributor

Sounds good, please squash merge.

@taesungh
Copy link
Member Author

The plan is to have #65 on standby and then merge this PR to verify the checks workflow fails because of a lingering type issue. Once that is verified, we can merge #65 to resolve the issue.

@taesungh taesungh linked an issue Dec 10, 2023 that may be closed by this pull request
@taesungh taesungh merged commit e2eafe6 into main Dec 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GitHub workflows to run ESLint and Prettier checks
2 participants