Add stubs for python3-saml to fix mypy errors #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use stubgen to generate stubs for onelogin.saml2.auth and onelogin.saml2.settings and fix imports - Add `stubs` directory to `mypy_path`
|
Deploy preview for irvinehacks-site-2024-sanity ready!
|
|
Deploy preview for irvinehacks-site-2024 ready!
|
samderanova
reviewed
Dec 10, 2023
samderanova
previously approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Looks good, let's merge #64 first and then squash merge this one whenever you're ready.
taesungh
added a commit
that referenced
this pull request
Dec 10, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
samderanova
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mypy to work in the checks workflow created in #64, we need to resolve lingering type issues.
This PR will be on standby as we merge #64 to verify the checks workflow will fail because of the type issue. We can merge this PR immediately after that which should resolve the issue. There will be a merge conflict in
pyproject.tomlfor which we take the version in this PR.Changes
stubsdirectory tomypy_path