Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Buffer Resource UAV collection + Cuda Surface Object Retrieval #2306

Conversation

liam-middlebrook
Copy link
Contributor

Fixes crashes when Buffer type resources are used for UAVInfo collection and CUDA Surface/Texture object retrieval.

This fixes a launch-time crash for Cyberpunk 2077 reported in jp7677/dxvk-nvapi#245 (comment)

Fixes a crash reported in jp7677/dxvk-nvapi#245 where capturing UAVInfo for a
buffer-resource would result in a segfault.

Signed-off-by: Liam Middlebrook <lmiddlebrook@nvidia.com>
Fixes a crash where calls to NvAPI_D3D12_GetCudaSurfaceObject() would
crash if a descriptor for a Buffer resource was provided. Proactively
makes the same fix for NvAPI_D3D12_GetCudaTextureObject().

Signed-off-by: Liam Middlebrook <lmiddlebrook@nvidia.com>
@eXt73
Copy link

eXt73 commented Jan 23, 2025

This build works brilliantly ;) > vkd3d-proton-merge-d9b96a3a992d9e3c921094472c88fcbb58373eff

Screenshot_20250124_004651
Screenshot_20250124_004719

@HansKristian-Work HansKristian-Work merged commit deeb3c1 into HansKristian-Work:master Jan 24, 2025
3 checks passed
@eXt73
Copy link

eXt73 commented Jan 25, 2025

.... but unfortunately these changes cause 'fade to black' in STALKER 2 ... similarly it was once in Cyberpunk ... the image immediately darkens until it becomes black when FG is turned on...

@Blisto91
Copy link
Contributor

Blisto91 commented Jan 26, 2025

@eXt73 Can you make a issue? I am not reproducing it so far in Stalker 2

@eXt73
Copy link

eXt73 commented Jan 26, 2025

@eXt73 Can you make a issue? I am not reproducing it so far in Stalker 2

Hi I'll try to do it this evening

@eXt73
Copy link

eXt73 commented Feb 2, 2025

@eXt73 Can you make a issue? I am not reproducing it so far in Stalker 2

Hi, I didn't add anything because I was still testing and I see that Proton Hotfix is ​​already working correctly under Stalker 2... However, another problem has appeared = in Cyberpunk 2077 - sometimes when I load certain saves, the screen flashes during loading, shows 'another random frame' and after loading the image starts to have 'afterimages' = you can see traces of the last few frames in the movement track = when FG is turned on...

@Blisto91
Copy link
Contributor

Blisto91 commented Feb 3, 2025

@eXt73 Hi again. Please make a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants