Submitter: fix backfill clamping + misc RPC selection fixes#987
Merged
Submitter: fix backfill clamping + misc RPC selection fixes#987
Conversation
…ck at the end of RPC selection
Deploying happychain with
|
| Latest commit: |
adeea56
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://511df9ad.happychain.pages.dev |
| Branch Preview URL: | https://ns-fix-flaky-rpc.happychain.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, our local node replica is fubared, it's lagging a few days behind the sequencer and making progress, albeit at a fraction of the normal pace.
This uncovered a bunch of interesting issues, and this is a first PR to address them.
This does not solve all the issues. We just haven't really considered this scenario where a RPC is live but largely trailing.
The main issue is not in the block subscription anymore, but in all the others RPC calls, which simply attempt to use the RPCs in the defined order, falling back in list order. The fix (for later) will be to implement a Viem client proxy that uses the RPC selected by the block service as its default block.