Skip to content

fix: address mode option in settings, tx history with error message, delayed loading modal in confirm send screen - #878

Merged
raul-oliveira merged 3 commits into
release-candidatefrom
fix/0.39.0-rc.2
May 29, 2026
Merged

fix: address mode option in settings, tx history with error message, delayed loading modal in confirm send screen#878
raul-oliveira merged 3 commits into
release-candidatefrom
fix/0.39.0-rc.2

Conversation

@raul-oliveira

@raul-oliveira raul-oliveira commented May 28, 2026

Copy link
Copy Markdown
Contributor

Acceptance Criteria

  • Sending transaction modal should appear right after the pin screen is dismissed in the send tokens flow
  • Address mode option should be feature flagged by the address mode feature flag
  • Tx history should appear without errors and refresh when the new tx arrives
  • Amounts shouldn't resize when interacting with the confirmation screen

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed layout issues with amount input fields causing unwanted text scaling
    • Improved transaction history cache refresh mechanism
    • Corrected address mode setting visibility
  • Improvements

    • Enhanced error messages for transaction failures, including specific shortage notifications

Review Change Stack

-> send amount sizing in the confirm send screen
-> tx history error message showing when invalidated state is set
-> address mode option showing based in the wrong feature flag
@raul-oliveira raul-oliveira self-assigned this May 28, 2026
@raul-oliveira
raul-oliveira requested a review from tuliomir May 28, 2026 19:48
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 92eb9679-b85e-4ef7-873c-0f3135dcb760

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/0.39.0-rc.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raul-oliveira raul-oliveira moved this from Todo to In Progress (Done) in Hathor Network May 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/screens/MainScreen.js`:
- Around line 101-103: The current condition only triggers getHistory when
status changes to TOKEN_DOWNLOAD_STATUS.INVALIDATED, so switching selectedToken
between two tokens that are both INVALIDATED skips refetch; update the
componentDidUpdate (or the block where status/prevStatus are checked) to also
call this.props.getHistory(this.props.selectedToken) when selectedToken has
changed AND the current status === TOKEN_DOWNLOAD_STATUS.INVALIDATED (i.e.,
check selectedToken !== prevSelectedToken || prevStatus !== status), using the
existing symbols status, prevStatus, selectedToken,
TOKEN_DOWNLOAD_STATUS.INVALIDATED and getHistory to locate and modify the logic.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9a5f979-e17f-460e-89cb-30e5863282de

📥 Commits

Reviewing files that changed from the base of the PR and between a7a2879 and 0ce637a.

📒 Files selected for processing (5)
  • src/components/AmountTextInput.js
  • src/screens/CreateTokenConfirm.js
  • src/screens/MainScreen.js
  • src/screens/SendConfirmScreen.js
  • src/screens/Settings.js

Comment thread src/screens/MainScreen.js
@tuliomir tuliomir moved this from In Progress (Done) to In Review (WIP) in Hathor Network May 28, 2026
@raul-oliveira
raul-oliveira merged commit 1ab2897 into release-candidate May 29, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Review (WIP) to Waiting to be deployed in Hathor Network May 29, 2026
@raul-oliveira raul-oliveira moved this from Waiting to be deployed to Done in Hathor Network Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants