fix: address mode option in settings, tx history with error message, delayed loading modal in confirm send screen - #878
Conversation
-> send amount sizing in the confirm send screen -> tx history error message showing when invalidated state is set -> address mode option showing based in the wrong feature flag
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/screens/MainScreen.js`:
- Around line 101-103: The current condition only triggers getHistory when
status changes to TOKEN_DOWNLOAD_STATUS.INVALIDATED, so switching selectedToken
between two tokens that are both INVALIDATED skips refetch; update the
componentDidUpdate (or the block where status/prevStatus are checked) to also
call this.props.getHistory(this.props.selectedToken) when selectedToken has
changed AND the current status === TOKEN_DOWNLOAD_STATUS.INVALIDATED (i.e.,
check selectedToken !== prevSelectedToken || prevStatus !== status), using the
existing symbols status, prevStatus, selectedToken,
TOKEN_DOWNLOAD_STATUS.INVALIDATED and getHistory to locate and modify the logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d9a5f979-e17f-460e-89cb-30e5863282de
📒 Files selected for processing (5)
src/components/AmountTextInput.jssrc/screens/CreateTokenConfirm.jssrc/screens/MainScreen.jssrc/screens/SendConfirmScreen.jssrc/screens/Settings.js
Acceptance Criteria
Security Checklist
Summary by CodeRabbit
Bug Fixes
Improvements