[v0.35.0] Sync master with release - #891
Conversation
Release candidate v0.35.0-rc.1
fix: upgrade wallet lib to v3.1.1 (#868)
… Home) (#878) The fee-token send refactor replaced the ModalPin/ModalSendTx flow with ModalTransactionOverview and ModalSendSuccess, dropping two behaviors: - The PIN field was no longer auto-focused. The overview modal relied on the input's `autoFocus`, which fires while the modal is still display:none, so the browser ignores it. Focus the field on Bootstrap's `shown.bs.modal` event instead (the old ModalPin approach), which also restores focus across every flow that uses the shared overview modal. - The success modal's "Close" (and top-right "x") only reset the form and stayed on the Send screen. They now navigate to the wallet home (/wallet/), restoring the pre-refactor behavior; the now-dead resetForm helper is removed.
… PIN) (#881) Fixes a batch of UX regressions introduced in the 0.35.0 release candidates: - Address mode kept across passphrase changes: adding/removing a passphrase no longer forces the wallet into multi-address mode. startWallet re-syncs the feature toggles from the live Unleash singleton before reading the single-address flag, so the clean_data reset in the passphrase flow no longer makes the flag read a stale default. - Import Tokens banner no longer advertises phantom tokens: unregistering a token with no history and zero balance now clears it from allTokens and tokensBalance, so fetchUnknownTokens stops reporting a token the import modal cannot resolve. - Easy Import Tokens "Open in Explorer" opens the system default browser via helpers.openExternalURL instead of a new Electron window. - Send Tokens confirmation validates the PIN with wallet.checkPin before sending, showing "Invalid PIN" on the review screen instead of a generic "Transaction failed" after a failed send attempt.
Release v0.35.0
📝 WalkthroughWalkthroughThis PR updates transaction PIN handling, send completion navigation, token explorer links, zero-balance token cleanup, feature-toggle synchronization, the package version, and a Lavamoat policy override. ChangesTransaction and token UI
Feature-toggle synchronization
Token metadata cleanup
Release and policy metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merge origin/release into master. Resolve package.json and package-lock.json conflict by keeping master's @hathor/hathor-rpc-handler 5.0.0 and stamping version 0.35.0.
0d65c9b to
23f5e44
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/reducers/index.js`:
- Around line 679-683: Update the cleanup logic around balance and newBalance so
a missing newBalance[uid] is treated the same as a strictly zero
available-plus-locked balance. Ensure both newBalance[uid] and newAllTokens[uid]
are deleted in either case, while preserving existing handling for nonzero
balances.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 29e58cde-914e-4135-bec6-52c115e2bb3a
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
lavamoat/webpack/policy-override.jsonpackage.jsonsrc/components/ModalTokenImport.jssrc/components/ModalTransactionOverview.jssrc/reducers/index.jssrc/sagas/featureToggle.jssrc/sagas/wallet.jssrc/screens/SendTokens.js
Acceptance Criteria
masterbranch with the changes from the latest releasev0.35.0Notes
masterwill be at version0.35.0with@hathor/hathor-rpc-handler5.0.0, a combination that the publishedv0.35.0package (built/tested with4.4.0) never shipped.masteradvanced past the release cut — feat: consent to dApp balance access at connection time #873 bumped@hathor/hathor-rpc-handler4.4.0→5.0.0and is not part of the0.35.0release. The conflict onpackage.json/package-lock.jsonwas resolved by keepingmaster's5.0.0and stamping the version to0.35.0, without touching thereleasebranch.Security Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Release