fix(amount): wrap long dashboard amounts instead of clipping - #895
Open
raul-oliveira wants to merge 1 commit into
Open
Conversation
The balance rows and the transaction-history Value column forced amounts onto a single line, clipping long values. Make each balance row a flex row so a wrapped value hangs under itself (the hanging indent from the design), and let the history Value column wrap with a min-width floor so it never collapses or ellipsizes. Layout only -- no formatting change. History value font and colour are intentionally left diverging from the mock; see the PR description.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
ValuecolumnmasterFourth of 6 PRs. Stacked on #894 — base branch is
raul-oliveira/feat/amount-format-radio, notmaster. Review #894 first.What changed
Layout only — no formatting logic.
WalletBalance.js: each balance row becomes a flex row (<div className="wallet-balance-row">+ a nowrap<strong>label + the existing<Amount>). The value is the flex item, so its continuation lines hang-indent under the value — the design's hanging indent, a free consequence of flex, no explicit indent.index.module.scss: new.wallet-balance*block; the existing#token-history .valuerule gainsmin-width: 12rem; white-space: normalso the column wraps and never collapses. No fixedwidth— the Figma columns are content-hugged.Left diverging from the mock on purpose (designer to confirm): history values keep the app's
monospace 1.2remand#28a745/#dc3545, where Figma shows 20px sans and#41A922/#A92224. The brief for this screen is wrapping only.Possible follow-up (out of scope, pre-existing): the Token Import modal's balance column (
.token-balance) useswhite-space: nowrap, so a long compressed amount could clip there. Not on the dashboard, not touched here.Testing
Suite unchanged from #894: the same 7 pre-existing suites fail on the Jest/axios ESM issue (see #892),
33 passed. No new strings.Manual QA needed
123,456,789,012,345,678.12345678): the value wraps to a second line that starts under the value, not the label.Valuecolumn: long values wrap to two lines, both flush right; the column does not collapse.master.Security Checklist