fix(amount): wrap long amounts in the transaction overview modal - #896
Open
raul-oliveira wants to merge 1 commit into
Open
Conversation
Long per-output amounts and the "You will pay" total were forced onto a single line and clipped. Let them wrap: drop the per-output nowrap and add overflow-wrap / min-width so the amount, the total and the network-fee value break instead of overflowing, and pin the direction arrow to the last wrapped line. Wrapping only -- no font-size change, no headline element, no structural change to the modal.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
masterFifth of 6 PRs. Stacked on #895 — base branch is
raul-oliveira/feat/amount-format-dashboard, notmaster. Review #895 first.What changed
Wrapping only — no formatting change, no font-size change, no headline element, no structural change to the modal. (The brief's "adapt the font size like mobile" targeted a headline amount the desktop modal doesn't have; the settled decision is wrapping-only.)
whiteSpace:'nowrap', addedoverflowWrap:'anywhere'+minWidth:0; the direction arrow is pinned to the last line withalignSelf:'flex-end'.overflowWrap:'anywhere',minWidth:0,lineHeight:20px, right-aligned) and the label getsflexShrink:0, so the value is what wraps rather than widening the row.overflowWrap:'anywhere'+minWidth:0, labelflexShrink:0. The "No fee" pill is untouched.Testing
Suite unchanged from #895: the same 7 pre-existing suites fail on the Jest/axios ESM issue (see #892),
33 passed. This component has no render test (the Jest env can't mount it); it is covered by the manual QA below.Manual QA needed
123,456,789,012,345,678.12345678: the per-output amount wraps and the direction arrow stays on the final line."… AAA + … HTR") wraps sensibly, and the network-fee value wraps too.modal-dialog; no horizontal scrollbar appears.Security Checklist