feat: complete pre-edit context evaluation gate - #256
Merged
Conversation
Close the documented acceptance gate for codebase_edit_context: - Add minGraphNeighborRecall budget threshold and wire it into the eval budget gate, schema parsing, and unit tests. - Add benchmarks/budgets/pre-edit.json with thresholds from the measured deterministic mock-embedding baseline (Hit@5 1.0, MRR@10 1.0, graph-neighbor recall 1.0, p95 687ms, avg response tokens 358.5). - Add eval:pre-edit:ci script and run it in CI after the eval smoke check. - Document the baseline metrics in docs/pre-edit-context-design.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the documented acceptance gate for
codebase_edit_contextfromdocs/pre-edit-context-design.md. The tool has shipped across OpenCode, MCP, and Pi, but the evaluation gate was unfinished: no budget file, no graph-neighbor recall threshold, no CI wiring, and no documented baseline.Changes
minGraphNeighborRecallthreshold toEvalBudget,parseBudget, andevaluateBudgetGate. It is only enforced when the metric is present, so datasets without graph-neighbor expectations are unaffected.benchmarks/budgets/pre-edit.jsonwith thresholds derived from the measured deterministic mock-embedding baseline.eval:pre-edit:cinpm script runs in.github/workflows/ci.ymlafter the eval smoke check, using the existing mock-embeddings server.docs/pre-edit-context-design.md; changelog updated.Measured baseline (mock embeddings)
Validation
npm run typecheck: passnpm run lint: passGate: passed=true violations=[]